[ http://jira.codehaus.org/browse/MAVEN-1786?page=all ]
Arnaud Heritier closed MAVEN-1786. ---------------------------------- Resolution: Fixed Fix Version/s: 1.1-rc1 It's working fine. Your algorithm is better and allow us to not create a new instance each time in the loop. > Performance Optimization of the Reactor > --------------------------------------- > > Key: MAVEN-1786 > URL: http://jira.codehaus.org/browse/MAVEN-1786 > Project: Maven > Issue Type: Improvement > Affects Versions: 1.1-beta-2 > Environment: OS windows xp, JVM sun 1.4.2 > Reporter: Emmanuel Renaud > Assigned To: Arnaud Heritier > Fix For: 1.1-rc1 > > Attachments: Goal.java, reactor-jprofiler.GIF > > > The Goal.checkForCycle method is a hotspot as the reactor starts. > Most of the time is spent in creating HashSets and filling them (see attached > screen shot). > Instead of creating a new HasSet each time, reusing the same improves the > performance of dependency analysis (see attached file Goal.java). > Due to security policy in my company I can't checkout the sources and run > non-regression tests, at least it works fine on our project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira