[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068759#comment-15068759
]
Michael Osipov edited comment on DOXIASITETOOLS-101 at 12/22/15 9:35 PM:
-------------------------------------------------------------------------
I would perform a massive cleanup, several months ago I have analyzed the code
throughout multiple levels and there are too many obsolete code:
1. DoxiaSiteRenderingContext: Drop publishDate, there is no point where you can
set the date, the decoration model doesn't provide. Drop Velocity property too.
2. DefaultSiteRenderer#createVelocityContext: remove dateCreation and add
creationDate as object
3. DefaultSiteRenderer#createVelocityContext: drop dateRevision it always
corresponds to the current date (redundant)
4. DefaultSiteRenderer#createVelocityContext: remove default date format
setting because publishDate can never be null in DeocrationModel (there is
always a null check in getPublishDate). Default is always set in the
DecorationModel
5. add isoDateFormat for the context formatting internal dates like generated
at header or meta fields.
6. Cleanup site.vms for the aforementioned points
For some of the points I have already created JIRA issues. For the rest, I
would create additional tickets too. Fully trackable.
What do you think?
was (Author: michael-o):
I would perform a massive cleanup, several months ago I have analyzed the code
throughout multiple levels and there are too many obsolete code:
1. DoxiaSiteRenderingContext: Drop publishDate, there is no point where you can
set the date, the decoration model doesn't provide. Drop Velocity property too.
2. DefaultSiteRenderer#createVelocityContext: remove dateCreation and add
creationDate as object
3. DefaultSiteRenderer#createVelocityContext: drop dateRevision it always
corresponds to the current date (redundant)
4. DefaultSiteRenderer#createVelocityContext: remove default date format
setting because publishDate can never be null in DeocrationModel (there is
always a null check in getPublishDate). Default is always set in the
DecorationModel
5. add isoDateFormat for the context formatting internal dates like generated
at header or meta fields.
6. Cleanup site.vms for the aforementioned points
For some of the points I have already created JIRA issues.
What do you think?
> Add ISO date format to site rendering context
> ---------------------------------------------
>
> Key: DOXIASITETOOLS-101
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-101
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
> Affects Versions: 1.6
> Reporter: Michael Osipov
> Fix For: 1.7
>
>
> Currently we have {{dateFormat}} only which depends on {{site.xml}}, we need
> a standardized format which can we used in meta tags as well as throughout
> the site, if necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
