[ 
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248553#comment-15248553
 ] 

Roman Ivanov edited comment on MJAVADOC-423 at 4/19/16 8:37 PM:
----------------------------------------------------------------

hmm, interesting...

Independent linux environment: 
https://github.com/checkstyle/checkstyle/pull/3120 , failure is shared at 
https://codeship.com/projects/124310/builds/14003186 
We do not have Windows build for this :( for now.
Command that is used in Codeship CI: 
https://github.com/checkstyle/checkstyle/issues/2727#issuecomment-172616360

My local:
{code}
✔  ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1] 
13:20 $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..2cbbaae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
             and http://jira.codehaus.org/browse/DOXIA-525 and 
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fixed -->
             <excludedLink>**/com/puppycrawl/**</excludedLink>
             <!-- Excluded due to Checkstyle's issue #549 until 
https://issues.apache.org/jira/browse/MJAVADOC-428 will be fixed -
-            
<excludedLink>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?*</excludedLink>
+            <!-- 
<excludedLink>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?*</excludedLink>
 
             <!-- Excluded due to Maven Enforcer Plugin's issue #234: 
https://issues.apache.org/jira/browse/MENFORCER-234-->
             
<excludedLink>http://maven.apache.org/enforcer/maven-enforcer-plugin</excludedLink>
             <!-- Excluded due to Maven Surefire Plugin's issue #1173: 
https://issues.apache.org/jira/browse/SUREFIRE-1173-->
{code}

{code}
✔  ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1] 
11:22 $ grep "404 Not Found" target/site/linkcheck.html 
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#error-org.xml.sax.SAXParseException-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#error-org.xml.sax.SAXParseException-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#fatalError-org.xml.sax.SAXParseException-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#fatalError-org.xml.sax.SAXParseException-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#resolveEntity-java.lang.String-java.lang.String-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#resolveEntity-java.lang.String-java.lang.String-</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#endElement-java.lang.String-java.lang.String-java.lang.String-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#endElement-java.lang.String-java.lang.String-java.lang.String-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-</a>:
 404 Not Found</i></td></tr></table></td></tr>
{code}

{code}
$ mvn --version
Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 
2014-06-17T06:51:42-07:00)
Maven home: /opt/maven/default
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family: "unix"
{code}



was (Author: romani):
hmm, interesting...

Independent linux environment: 
https://github.com/checkstyle/checkstyle/pull/3120 , failure will be 
https://codeship.com/projects/124310/builds/14003186 
We do not have Windows build for this :( for now.
Command that is used in Codeship CI: 
https://github.com/checkstyle/checkstyle/issues/2727#issuecomment-172616360

My local:
{code}
✔  ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1] 
13:20 $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..2cbbaae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
             and http://jira.codehaus.org/browse/DOXIA-525 and 
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fixed -->
             <excludedLink>**/com/puppycrawl/**</excludedLink>
             <!-- Excluded due to Checkstyle's issue #549 until 
https://issues.apache.org/jira/browse/MJAVADOC-428 will be fixed -
-            
<excludedLink>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?*</excludedLink>
+            <!-- 
<excludedLink>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?*</excludedLink>
 
             <!-- Excluded due to Maven Enforcer Plugin's issue #234: 
https://issues.apache.org/jira/browse/MENFORCER-234-->
             
<excludedLink>http://maven.apache.org/enforcer/maven-enforcer-plugin</excludedLink>
             <!-- Excluded due to Maven Surefire Plugin's issue #1173: 
https://issues.apache.org/jira/browse/SUREFIRE-1173-->
{code}

{code}
✔  ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1] 
11:22 $ grep "404 Not Found" target/site/linkcheck.html 
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#error-org.xml.sax.SAXParseException-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#error-org.xml.sax.SAXParseException-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#fatalError-org.xml.sax.SAXParseException-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#fatalError-org.xml.sax.SAXParseException-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#resolveEntity-java.lang.String-java.lang.String-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#resolveEntity-java.lang.String-java.lang.String-</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-</a>:
 404 Not Found</i></td></tr></table></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#endElement-java.lang.String-java.lang.String-java.lang.String-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#endElement-java.lang.String-java.lang.String-java.lang.String-</a>:
 404 Not Found</i></td></tr>
<td><i><a class="externalLink" 
href="http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-";>http://docs.oracle.com/javase/7/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true#startElement-java.lang.String-java.lang.String-java.lang.String-org.xml.sax.Attributes-</a>:
 404 Not Found</i></td></tr></table></td></tr>
{code}

{code}
$ mvn --version
Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 
2014-06-17T06:51:42-07:00)
Maven home: /opt/maven/default
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family: "unix"
{code}


> wrong link generation for org.xml.sax.helpers.DefaultHandler
> ------------------------------------------------------------
>
>                 Key: MJAVADOC-423
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-423
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 2.10.1
>            Reporter: Roman Ivanov
>         Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin - 
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
>  404 Not Found
> "
> problem is in  "helpers.DefaultHandler.html" should be 
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle 
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to