[
https://issues.apache.org/jira/browse/SCM-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated SCM-833:
------------------------------------
Description:
Currently there is a method like this in the code (buildnumber-maven-plugin):
AbstractScmMojo.java:
{code:java}
protected String getScmRevision()
throws ScmException
{
ScmRepository repository = getScmRepository();
InfoScmResult scmResult = info( repository, new ScmFileSet(
scmDirectory ) );
if ( scmResult == null || scmResult.getInfoItems().isEmpty() )
{
return ( !StringUtils.isEmpty( revisionOnScmFailure ) ) ?
revisionOnScmFailure : null;
}
checkResult( scmResult );
InfoItem info = scmResult.getInfoItems().get( 0 );
List<InfoItem> infoItems = scmResult.getInfoItems();
for (InfoItem infoItem : infoItems) {
getLog().info("Item: " +infoItem.getRevision() + " lcr: " +
infoItem.getLastChangedRevision() );
}
getLog().info("useLastCommittedRevision: " + useLastCommittedRevision);
if ( useLastCommittedRevision )
{
return info.getLastChangedRevision();
}
return info.getRevision();
}
{code}
The problem is simply that {{getLastChangedRevision()}} returns null whereas
{{getRevision()}} returns the requested value?...
So ATM I'm not sure if this is really a bug in SCM or a misusage in
buildnumber-maven-plugin ?
was:
Currently there is a method like this in the code (buildnumber-maven-plugin):
AbstractScmMojo.java:
{code:java}
protected String getScmRevision()
throws ScmException
{
ScmRepository repository = getScmRepository();
InfoScmResult scmResult = info( repository, new ScmFileSet(
scmDirectory ) );
if ( scmResult == null || scmResult.getInfoItems().isEmpty() )
{
return ( !StringUtils.isEmpty( revisionOnScmFailure ) ) ?
revisionOnScmFailure : null;
}
checkResult( scmResult );
InfoItem info = scmResult.getInfoItems().get( 0 );
List<InfoItem> infoItems = scmResult.getInfoItems();
for (InfoItem infoItem : infoItems) {
getLog().info("Item: " +infoItem.getRevision() + " lcr: " +
infoItem.getLastChangedRevision() );
}
getLog().info("useLastCommittedRevision: " + useLastCommittedRevision);
if ( useLastCommittedRevision )
{
return info.getLastChangedRevision();
}
return info.getRevision();
}
{code}
The problem is simply that {{getLastChangedRevision()}} returns null whereas
{{getRevision()}} returns the requested value?...
> getLastChangedRevision() returns null whereas as getRevision() get correct
> versions
> -----------------------------------------------------------------------------------
>
> Key: SCM-833
> URL: https://issues.apache.org/jira/browse/SCM-833
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api, maven-scm-provider-jgit
> Affects Versions: 1.9.4
> Reporter: Karl Heinz Marbaise
>
> Currently there is a method like this in the code (buildnumber-maven-plugin):
> AbstractScmMojo.java:
> {code:java}
> protected String getScmRevision()
> throws ScmException
> {
> ScmRepository repository = getScmRepository();
> InfoScmResult scmResult = info( repository, new ScmFileSet(
> scmDirectory ) );
> if ( scmResult == null || scmResult.getInfoItems().isEmpty() )
> {
> return ( !StringUtils.isEmpty( revisionOnScmFailure ) ) ?
> revisionOnScmFailure : null;
> }
> checkResult( scmResult );
> InfoItem info = scmResult.getInfoItems().get( 0 );
>
> List<InfoItem> infoItems = scmResult.getInfoItems();
>
> for (InfoItem infoItem : infoItems) {
> getLog().info("Item: " +infoItem.getRevision() + " lcr: " +
> infoItem.getLastChangedRevision() );
> }
> getLog().info("useLastCommittedRevision: " +
> useLastCommittedRevision);
> if ( useLastCommittedRevision )
> {
> return info.getLastChangedRevision();
> }
> return info.getRevision();
> }
> {code}
> The problem is simply that {{getLastChangedRevision()}} returns null whereas
> {{getRevision()}} returns the requested value?...
> So ATM I'm not sure if this is really a bug in SCM or a misusage in
> buildnumber-maven-plugin ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
