[ 
https://issues.apache.org/jira/browse/MNG-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408507#comment-15408507
 ] 

Hervé Boutemy commented on MNG-6059:
------------------------------------

I'm not convinced by {{project/@child.inherit.append.path="url"}}: this would 
make users think that other fields than url can be selected

IIUC, since there are 3 different attributes, let's have 3 different names: 
having the same name just cause confusion (and, with my limited english, I 
can't even understand your explanations about "same")

once the 3 attributes will have different names, I think it'll be easier to 
continue about {{child.scm.inherit.append.path}}, which is the only case where 
we need updates

> Important use cases not covered, as child.inherit.append.path affects all 
> children
> ----------------------------------------------------------------------------------
>
>                 Key: MNG-6059
>                 URL: https://issues.apache.org/jira/browse/MNG-6059
>             Project: Maven
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>         Environment: Apache Maven 3.4.0-SNAPSHOT 
> (227085283b6379038ec16f4cf9ad2e8869cef694; 2016-07-06T21:29:12+02:00)
>            Reporter: Andreas Sewe
>            Assignee: Hervé Boutemy
>             Fix For: 3.4.0
>
>
> The {{child.inherit.append.path}} attribute introduced with MNG-5951 
> unfortunately does not support the use case where the children of the element 
> with the attribute should follow different inheritance rules. Take a typical 
> configuration for Github, for example (taken from 
> <http://central.sonatype.org/pages/requirements.html>):
> {noformat}
> <scm>
>   
> <connection>scm:git:git://github.com/simpligility/ossrh-demo.git</connection>
>   
> <developerConnection>scm:git:ssh://github.com:simpligility/ossrh-demo.git</developerConnection>
>   <url>http://github.com/simpligility/ossrh-demo/tree/master</url>
> </scm>
> {noformat}
> If the {{ossrh-demo.git}} repository contains a child module called 
> {{some-module}}, then that child’s {{scm/url}} should become 
> {{http://github.com/simpligility/ossrh-demo/tree/master/some-module}} as per 
> the normal inheritance rules, but both the {{scm/connection}} and 
> {{scm/developerConnection}} URLs should remain unchanged.
> Unfortunately, this is not possible with {{*child*.inherit.append.path}}, 
> which acts on all children simultaneously.
> IMHO, this is a conceptual problem. In particular, setting 
> {{child.inherit.append.path}} on the *root* element to just control a single 
> child ({{project/url}}) feels wrong, as the attribute is in all likelihood 
> not even located close to the {{<url>}} element it controls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to