[
https://issues.apache.org/jira/browse/MSHADE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858411#comment-15858411
]
Michael Osipov edited comment on MSHADE-248 at 2/8/17 7:21 PM:
---------------------------------------------------------------
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. As you can see,
Maven already gives you a warning that there is something wrong with the JAR.
Basically, no plugin interacting with ZIP files does a content validation.
During dep download it is assumed that the ZIP file is validated against its
checksum and in case of a problem, you'll see the warning. What would you
expect to see?
was (Author: michael-o):
bq. In any case, it sounds like you don't agree the shade plugin should be more
lenient. That's cool.
I didn't say that. I wanted to understand the root cause first. Can you rebuild
the project with a empty repo? It should give you a checksum warning. I'd like
to see this first.
> shading fails with "error in opening zip file" if createSourcesJar=true and
> an invalid sources jar file is encountered
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: MSHADE-248
> URL: https://issues.apache.org/jira/browse/MSHADE-248
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.4.3
> Reporter: Ian Springer
>
> {code}
> Downloading:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is
> b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Could not validate integrity of download from
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar:
> Checksum validation failed, expected <!DOCTYPE but is
> b95d8d7d1a57cf46d9f0e924f8864f94159bffd3
> [WARNING] Checksum validation failed, expected <!DOCTYPE but is
> b95d8d7d1a57cf46d9f0e924f8864f94159bffd3 for
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> Downloaded:
> https://foo.repo.com/nexus/content/groups/foo/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar
> (2 KB at 1.3 KB/sec)
> {code}
> And then:
> {code}
> ------------------------------------------------------------------------
> BUILD FAILURE
> ------------------------------------------------------------------------
> Total time: 18.486 s
> Finished at: 2017-02-07T11:13:11-05:00
> Final Memory: 72M/977M
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:2.4.3:shade (shade) on project
> jclouds-shaded: Error creating shaded jar: error in opening zip file
> /Users/ips/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4-sources.jar ->
> [Help 1]
> {code}
> bsh is a transitive dep of one of the jars I am shading. Since I can't
> control the fact that they have an invalid sources jar published, the shade
> plugin should be more forgiving and just log a warning and skip the bsh
> sources jar when building the shaded sources jar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
