[ https://issues.apache.org/jira/browse/MNG-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862429#comment-15862429 ]
Hudson commented on MNG-5934: ----------------------------- SUCCESS: Integrated in Jenkins build maven-3.x #1543 (See [https://builds.apache.org/job/maven-3.x/1543/]) [MNG-5934] String handling issues identified by PMD (michaelo: [http://git-wip-us.apache.org/repos/asf/?p=maven.git&a=commit&h=8d91726f7872f4462d9fa085ef5b6f32bfd0a2e1]) * (edit) maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java * (edit) maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java * (edit) maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/UnsupportedSlf4jBindingConfiguration.java * (edit) maven-core/src/main/java/org/apache/maven/repository/ArtifactTransferEvent.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/resolver/MultipleArtifactsNotFoundException.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java * (edit) maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java * (edit) maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java * (edit) maven-settings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsProblem.java * (edit) maven-core/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java * (edit) maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java * (edit) maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java * (edit) maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java * (edit) maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java * (edit) maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java * (edit) maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java * (edit) maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java * (edit) maven-builder-support/src/main/java/org/apache/maven/building/DefaultProblem.java * (edit) maven-core/src/main/java/org/apache/maven/plugin/MojoExecution.java * (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java * (edit) maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java * (edit) maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecyclePhase.java * (edit) maven-core/src/main/java/org/apache/maven/artifact/repository/MavenArtifactRepository.java * (edit) maven-core/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolutionResult.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java * (edit) maven-compat/src/test/java/org/apache/maven/project/LegacyLocalRepositoryManager.java * (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java * (edit) maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java * (edit) maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java * (edit) maven-core/src/main/java/org/apache/maven/repository/legacy/metadata/AbstractArtifactMetadata.java * (edit) maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java * (edit) maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java * (edit) maven-core/src/main/java/org/apache/maven/project/MavenProject.java * (edit) maven-compat/src/main/java/org/apache/maven/artifact/repository/DefaultArtifactRepository.java * (edit) maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Restriction.java > String handling issues identified by PMD > ---------------------------------------- > > Key: MNG-5934 > URL: https://issues.apache.org/jira/browse/MNG-5934 > Project: Maven > Issue Type: Improvement > Affects Versions: 3.3.9 > Reporter: Alex Henrie > Assignee: Michael Osipov > Priority: Minor > Labels: easyfix, newbie, patch, performance > Fix For: 3.5.0 > > Attachments: > 0001-Prefer-StringBuilder.append-char-to-StringBuilder.ap.patch, > 0002-Prefer-String.indexOf-char-to-String.indexOf-String.patch, > 0003-Combine-string-literals-instead-of-calling-String.ap.patch, > 0004-Construct-StringBuffers-with-enough-space-to-begin-w.patch > > > The code linting tool [PMD|http://pmd.sourceforge.net/pmd-5.2.0/] identified > numerous places where Maven's string handling is inefficient. I've prepared a > set of patches that should help speed things up. > The command I used was `pmd -d . -R java-strings` -- This message was sent by Atlassian JIRA (v6.3.15#6346)