[ http://jira.codehaus.org/browse/MCHANGELOG-16?page=comments#action_77647 ] Julian Wood commented on MCHANGELOG-16: ---------------------------------------
Dennis, I think you are missing a lot of information. I haven't had time to look in detail, but let me fill you in from what I know, and what I suspect. 1. The decision to close - websvncommons? That is just our URL. Not the name of the presentation system, which is websvn (http://websvn.tigris.org/) Try looking that up in google :-) As far as I know, not just svn, but every web presentation system has a different url for to show the listing of a directory vs the detailed changes or the printout of a file, which was the point of this change. I don't know how you can justify forcing a single URL on developers to cover all potential cases. 2. I suspect that your conclusion that it breaks other systems is wrong. We basically add one 'if' clause to a number of others, to account for this case in particular. The other cases were untouched. That in itself should give you confidence in the patch. We tested it with other systems and it was fine with everyone for over 6 months. So I think there was some other coincidental problem that you encountered. And if there was a problem, how could it be anything more than a trivial fix? Why was the problem never described, at all? I'm sure your new problem would be easy to fix. So, I'm going to reopen the issue, because I think it's incredibly valuable to be able to click on the link in the changelog, and actually see the file you clicked on (which does not work without such a patch). > when using svn, links are wrong > ------------------------------- > > Key: MCHANGELOG-16 > URL: http://jira.codehaus.org/browse/MCHANGELOG-16 > Project: Maven 2.x Changelog Plugin > Issue Type: Improvement > Affects Versions: 2.0 > Environment: osx 10.4.5, java 1.4.2_09 > Reporter: Julian Wood > Priority: Minor > Attachments: MCHANGELOG-16.patch, test.zip > > > Here's my setup: > <scm> > <connection>scm:svn:http://apollo.ucalgary.ca:8800/pmgt/trunk</connection> > > <developerConnection>scm:svn:http://apollo.ucalgary.ca:8800/pmgt/trunk</developerConnection> > > <url>http://apollo.ucalgary.ca/websvncommons/listing.php?repname=pmgt&rev=0&sc=0&path=/trunk</url> > </scm> > ... > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-changelog-plugin</artifactId> > <version>2.0-beta-2-SNAPSHOT</version> > <reportSets> > <reportSet> > <id>changes</id> > <configuration> > > <displayFileDetailUrl>http://apollo.ucalgary.ca/websvncommons/filedetails.php?repname=pmgt&rev=0&sc=0&path=</displayFileDetailUrl> > <type>range</type> > <range>90</range> > </configuration> > <reports> > <report>changelog</report> > <report>file-activity</report> > <report>dev-activity</report> > </reports> > </reportSet> > </reportSets> > </plugin> > With that displayFileDetailUrl, I get links like this in the resultant > changelog in my site: > http://apollo.ucalgary.ca/websvncommons/filedetails.php/trunk/pmgt-webapp/src/main/webapp/links/create_groups.jsp?repname=pmgt&sc=0&path= > but it should be like this: > link = > http://apollo.ucalgary.ca/websvncommons/filedetails.php?repname=pmgt&sc=0&rev=0&path=/trunk/pmgt-webapp/src/main/webapp/links/create_groups.jsp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
