[
https://issues.apache.org/jira/browse/SUREFIRE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258416#comment-16258416
]
ASF GitHub Bot commented on SUREFIRE-1424:
------------------------------------------
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860152
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
---
@@ -78,12 +83,13 @@ public void
shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
.addGoal( "--toolchains" )
.addGoal( System.getProperty(
"maven.toolchains.file" ) )
.execute( "verify" )
- .verifyErrorFree( 2 );
+ .verifyErrorFree( 1 );
--- End diff --
I have dropped tet_corba_mod.
It is not possible to have legacy "corba module" + dependency of JTA,
because module java.corba require legacy transaction packages which be loaded
from the JDK and so in turn this will hide the explicit dependency.
I could create one more IT only for corba
> javax.transaction.TransactionManager not visible with Java9
> -----------------------------------------------------------
>
> Key: SUREFIRE-1424
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1424
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 2.20.1
> Environment: Apache Maven 3.5.0
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
> Maven home: /Users/snicoll/tools/maven
> Java version: 9, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
> Default locale: en_BE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> Reporter: Stephane Nicoll
> Assignee: Tibor Digana
>
> I am trying to port Spring Boot to Java9 and I am hitting an issue that looks
> like Maven specific. I've managed to trim down the problem to [a simple class
> that doesn't involve Spring
> Boot|https://github.com/snicoll-scratches/test-jta-java9]
> If I run this project on the command line, I get the following:
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.043 s <<<
> FAILURE! - in com.example.testjtajava9.TestJtaJava9ApplicationTests
> contextLoads(com.example.testjtajava9.TestJtaJava9ApplicationTests) Time
> elapsed: 0.006 s <<< ERROR!
> java.lang.NoClassDefFoundError: javax/transaction/TransactionManager
> at
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> Caused by: java.lang.ClassNotFoundException:
> javax.transaction.TransactionManager
> at
> com.example.testjtajava9.TestJtaJava9ApplicationTests.contextLoads(TestJtaJava9ApplicationTests.java:9)
> {noformat}
> If I run that test with IntelliJ IDEA, it passes. This sample project has
> also a simple Gradle build that shows it works with Gradle as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
