[ http://jira.codehaus.org/browse/MDEP-29?page=comments#action_78836 ] 
            
Jimisola Laursen commented on MDEP-29:
--------------------------------------

Brian, you changed my patched and introduced a bug!

My patch contained the line following line in DependencyStatusSets:

log.info( "   " + artifact.getId()  + (outputArtifactFilename ? ":" + 
artifact.getFile().getAbsoluteFile() : ""));

you refactored a bit:

artifactFilename = artifact.getFile().getAbsoluteFile().getName();


However, getName() doesn't return the absolute path and filename, i.e. 
/tmp/x.txt becomes x.txt.

artifactFilename = artifact.getFile().getAbsoluteFile().getName();

should be:

artifactFilename = artifact.getFile().getAbsoluteFile().toString();

or 

artifactFilename = artifact.getFile().getAbsolutePath();


Would you be so kind and fix this and also create a new snapshot like today?




> Make (sure) dependency:resolve outputs absolute filename (or at least make it 
> configurable)
> -------------------------------------------------------------------------------------------
>
>                 Key: MDEP-29
>                 URL: http://jira.codehaus.org/browse/MDEP-29
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.0, 2.0
>            Reporter: Jimisola Laursen
>         Assigned To: Brian Fox
>             Fix For: 2.0-alpha-1
>
>         Attachments: MDEP-29-patch-2.diff, MDEP-29.diff
>
>
> I haven't used 1.1/2.0 yet myself, but from Brian Fox's comment 
> (http://jira.codehaus.org/browse/MDEP-24#action_69078) it's uncertain whether
> dependency:resolve outputs the absolute filename at all times.
> Being able to specify whether the output should be filename onlhy or  
> absolute filename would be very useful.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to