[
https://issues.apache.org/jira/browse/SUREFIRE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678708#comment-16678708
]
ASF GitHub Bot commented on SUREFIRE-1588:
------------------------------------------
jglick opened a new pull request #198: [SUREFIRE-1588] Correcting
relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198
Amends #197 or the commits it turned in to. The root issue is that
`Path.relativize` uses a native path separator while `URI.path` expects `/`.
Observed errors running Jenkins functional tests on a Windows CI machine in
which the system temporary directory (used for the booter as of
[SUREFIRE-1400](https://issues.apache.org/jira/browse/SUREFIRE-1400)) used the
same drive as the local repository, and Surefire thus attempted relativization.
(When the drives were different, it falls back to the original behavior of
using absolute paths, which still works at least on the Windows JDK 8u191. This
made it harder for me to reproduce at first. Passing `-Djava.io.tmpdir=…` to
`mvn` allows it to be reproduced locally, and to confirm that the test passes
when using a snapshot version of Surefire.)
The problem was that `Class-Path` entries included nonsense URIs with
components like `..%5C` rather than `../`. The Java class loader is apparently
able to load classes from the result, but then the
`Class.protectionDomain.codeSource.location` is weird.
@Tibor17 @cstamas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8
> -----------------------------------------------------------------------
>
> Key: SUREFIRE-1588
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1588
> Project: Maven Surefire
> Issue Type: Bug
> Affects Versions: 2.22.1
> Reporter: Cservenak, Tamas
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 3.0.0-M1
>
>
> See issue [1], but in short: latest Java8 on Ubuntu/Debian/Mint family of
> Linuxes (am on Mint, Ubuntu derivative) contains this patch [3], and eforces
> Manifest class path entries to be relative, as defined in [2].
> Hence, surefire booter and rest of Maven classpath, that uses absolute URLs
> are simply discarded.
> Example error:
> {noformat}
> # Created at 2018-10-30T21:34:43.339
> Error: Could not find or load main class
> org.apache.maven.surefire.booter.ForkedBooter{noformat}
> using the new property
> {{-Djdk.net.URLClassPath.disableClassPathURLCheck=debug}} clearly shows that
> all the entries from the surefire JAR are simply ignored.
>
> [1] [https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925]
> [2]
> https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.html#classpath
> [3] [https://hg.openjdk.java.net/jdk/jdk/rev/27135de165ac]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
