[
https://issues.apache.org/jira/browse/WAGON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684443#comment-16684443
]
Michael Osipov commented on WAGON-538:
--------------------------------------
So, I went through our code and through HttpClient. The parameter is never
read. If you take a look at {{ConfigurationUtils}}, it takes a bunch of
predefined parameters and maps them to {{RequestConfig.Builder#setXXX()}}.
There is no setter for this value anymore. The part where params are evaluated
in HttpClient aren't set by Wagon at all. The entire config setup predates
HttpClient 4. It needs an overhaul. The setting is just a no-op.
> Basic authentication fails if the password contains non-ascii characters
> ------------------------------------------------------------------------
>
> Key: WAGON-538
> URL: https://issues.apache.org/jira/browse/WAGON-538
> Project: Maven Wagon
> Issue Type: Bug
> Reporter: Aleksander Gjermundsen
> Priority: Major
>
> If the username and/or password used to authenticate to Nexus contains
> non-ascii characters, the authentication fails with an access denied error.
> After using Wireshark to investigate the headers being sent (in my case "Ø",
> any non-ascii characters are replaced with "?".
> To test, I have used the following configuration:
> {code:java}
> <settings xmlns="http://maven.apache.org/SETTINGS/1.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd";>
> ...
> <servers>
> <server>
> <id>artifactory</id>
> <username>userØ</username>
> <password>userØ</password>
> </server>
> </servers>
> ...
> <mirrors>
> <mirror>
> <id>nexus</id>
> <mirrorOf>*</mirrorOf>
> <name>Local Nexus</name>
> <url>http://localhost:8081/repository/maven-public</url>
> </mirror>
> </mirrors>
> ...
> </settings>{code}
> The settings.xml file is saved using UTF-8 encoding and it appears that Maven
> reads the username and passwords correctly into strings, but Apache
> HttpClient do not encode the UTF-8 characters when encoding them into base64.
> I did a quick patch of Wagon to make it work for my use case, where
> HttpClient is configured to encode as UTF-8. As is mentioned in MNG-5917, it
> is not completely clear from the standards how these characters are supposed
> to be handled, but on my system both wget and the Chrome web browser encode
> the characters the same way as after my patch and are able to download files
> from Nexus.
> Since Artifactory was used in MNG-5917, I also tested against that, but in
> contrast to Maven it was not able to decode the username and password
> correctly, however it would be broken without the patch anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
