[ 
https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700887#comment-16700887
 ] 

Robert Scholte commented on MNG-6311:
-------------------------------------

[~mickael.istria] based on the comments this commit seems to improve the 
performance a lot, so I don't think that reverting is the right solution. 
Instad I would suggest to create a new issue to improve the cache even more, 
keeping IDEs in mind.

> Maven intolerably slow when import scope used heavily in large project
> ----------------------------------------------------------------------
>
>                 Key: MNG-6311
>                 URL: https://issues.apache.org/jira/browse/MNG-6311
>             Project: Maven
>          Issue Type: Bug
>          Components: core, Performance
>    Affects Versions: 3.5.0, 3.5.2
>            Reporter: David Churcher
>            Assignee: Sylwester Lachiewicz
>            Priority: Major
>              Labels: performance
>             Fix For: 3.6.0
>
>         Attachments: Call-tree-–-All-threads-together.html, 
> anon-hierarchy-maven-output.zip, modelcachefix.diff
>
>
> I have a build performance problem that is identical to MNG-5312, and has 
> appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, 
> removing the ModelCache from some of the overloads for 
> DefaultProjectBuilder.build. 
> As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 
> levels of parent POMs, many of which use the import scope and have large 
> dependency-management sections, and has hundreds of dependencies that also 
> use the same parent POM hierarchy. Adding some logging shows that Maven does 
> over 800,000 uncached reads of parent POM files, which takes about half an 
> hour. With model caching this goes down to a few seconds.
> I've attached a patch that fixes this by using a class-level ModelCache in 
> DefaultProjectBuilder. This does not suffer from the memory usage problems 
> reported in MNG-6030.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to