michael-o commented on a change in pull request #125: [MNG-5965] Parallel build
multiplies work if multiple goals are given
URL: https://github.com/apache/maven/pull/125#discussion_r243990973
##########
File path:
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/multithreaded/ConcurrencyDependencyGraph.java
##########
@@ -61,12 +61,12 @@ public int getNumberOfBuilds()
/**
* Gets all the builds that have no reactor-dependencies
*
- * @return A list of all the initial builds
+ * @return A set of all the initial builds
*/
- public List<MavenProject> getRootSchedulableBuilds()
+ public Set<MavenProject> getRootSchedulableBuilds()
{
- List<MavenProject> result = new ArrayList<>();
+ Set<MavenProject> result = new HashSet<>();
Review comment:
I think this should be `LinkedHashSet` to retain Insertion order just like
`ArrayList` does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
