[
https://issues.apache.org/jira/browse/SCM-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732760#comment-16732760
]
Michael Osipov commented on SCM-777:
------------------------------------
[~hboutemy], as far as I understand the overall design there is no way to pass
around this piece of information easily. Sys property or thread local storage
are the only viable options. I do feel confident on the patch because it is
straight forward, but I'd be happy if you could spare an hour or so to think
about your previous approach and tell whether the change is legit.
> scm:validate ignores scmCheckWorkingDirectoryUrl configuration in favor of
> system property
> ------------------------------------------------------------------------------------------
>
> Key: SCM-777
> URL: https://issues.apache.org/jira/browse/SCM-777
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-plugin
> Affects Versions: 1.9.1
> Environment: Java 7 x64 on Windows 7
> Reporter: Mark Herman
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.11.2
>
>
> org.apache.maven.scm.manager.AbstractScmManager.checkWorkingDirectoryUrl()
> uses... {code} Boolean.getBoolean( CHECK_WORKING_DIRECTORY_URL ) {code}
> ...in order to check if it should check the repository on scm:validate. This
> will only react to the system property, and not to the maven configuration.
> *Result:* no maven config will enable the check working directory option,
> only passing it in as a jvm argument.
> *Expected:* this should work:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-scm-plugin</artifactId>
> <configuration>
> <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl> <!--
> this configuration is ignored, don't know why -->
> </configuration>
> <executions>
> <execution>
> <phase>validate</phase>
> <configuration>
> <scmCheckWorkingDirectoryUrl>true</scmCheckWorkingDirectoryUrl>
> <!-- neither does this -->
> </configuration>
> <goals>
> <goal>validate</goal>
> </goals>
> </execution>
> </executions>
> </plugin>
> {code}
> *Workaround:* Use <systemProperty> section. Tried <systemPropertyVariables>
> and for some reason that didn't appear to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
