rfscholte commented on a change in pull request #7: [MPIR-375] add plugin
excludes feature for plugin-management report
URL:
https://github.com/apache/maven-project-info-reports-plugin/pull/7#discussion_r247358087
##########
File path:
src/main/java/org/apache/maven/report/projectinfo/PluginManagementReport.java
##########
@@ -255,5 +283,41 @@ public int compare( Plugin a1, Plugin a2 )
}
};
}
+
+ private boolean isExcluded( Artifact pluginArtifact )
+ {
+ if ( excludes == null )
+ {
+ return false;
+ }
+
+ for ( String pattern : excludes )
+ {
+ String[] subStrings = pattern.split( ":" );
Review comment:
I don't see a reason to cleanup the pattern. This is already a list, not a
single comma-separated String.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
