rfscholte commented on a change in pull request #19: [MSHADE-316] -
Configuration option <excludeDefaults>
URL: https://github.com/apache/maven-shade-plugin/pull/19#discussion_r275162538
##########
File path:
src/main/java/org/apache/maven/plugins/shade/filter/SimpleFilter.java
##########
@@ -42,16 +42,19 @@
private Set<String> excludes;
+ private boolean excludeDefaults = true;
+
/**
* @param jars set of {@link File}s.
* @param includes set of includes.
* @param excludes set of excludes
*/
- public SimpleFilter( Set<File> jars, Set<String> includes, Set<String>
excludes )
+ public SimpleFilter( Set<File> jars, Set<String> includes, Set<String>
excludes, boolean excludeDefaults )
Review comment:
IMHO this is more an improvement than a bugfix. And I'm not sure if others
use this SimpleFilter as superclass, so better to keep the original constructor
anyway. I don't like the idea that every new field for ArchiveFilter would
translate to an extra constructor, just pass the original instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
