[ 
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817592#comment-16817592
 ] 

Romain Manni-Bucau commented on SUREFIRE-1546:
----------------------------------------------

Hi guys,

Have to admit you lost me. Here is how I see things:

- test execution is always a tree - even more with junit5 but was the case 
before even if less used. Surefire must just respect the provider here and not 
create its own api or way to do which is not accessible from IDE,
- if a dev put a display name it is to make the console and report human 
friendly so it must be used,
- class and method names are valuable and should be preserved

My conclusion is that surefire must track this tree with meta like display name 
and fqn + probably move its report to a tree as often reported by native 
reporters. It is a bit of work but is portable and solves that 
dynamic/parameterized test issue cleanly. Alternatives sound like affecting 
negatively the users so I would love to avoid that.

Hope it makes sense.

> JUnit 5 runner does not honor JUnit 5 display names
> ---------------------------------------------------
>
>                 Key: SUREFIRE-1546
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support
>    Affects Versions: 2.22.0
>            Reporter: Romain Manni-Bucau
>            Assignee: Tibor Digana
>            Priority: Major
>              Labels: junit5
>             Fix For: 3.0.0-M4
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the 
> classname if any is defined. Seems last release doesn't support that feature 
> of JUnit 5 making the console output and reports not the expected ones.
>  
> Origin: https://github.com/junit-team/junit5/issues/990



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to