[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843205#comment-16843205
]
Enrico Olivelli commented on MCHECKSTYLE-376:
---------------------------------------------
That integration test has been introduced during laat weeks, just before
cutting the 3.1.0.
Apart from this it is strange that on Apache CI even in windows machine the
test is passing.
It does not pass in case of a fresh git clone on windows.
Maybe this is only due to how jenkins works. But honestly I don't understand
the cause.
Is jenkins cloning the git repo only once and then copying the files to other
'agents'? In this case it may bhappen that it clones the project on a unix
machine and then transfers the repository to windows agents and replaces line
endings? Like usually FTP clients do
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> ------------------------------------------------------------------------------------------
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
> Reporter: Tibor Digana
> Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
