ascheman commented on a change in pull request #3: [MGPG-71] - Plugin does not
work with GPG on OSX based on MacGPG2
URL: https://github.com/apache/maven-gpg-plugin/pull/3#discussion_r307954411
##########
File path: src/main/java/org/apache/maven/plugin/gpg/GpgVersionParser.java
##########
@@ -37,12 +37,11 @@
*/
public class GpgVersionParser
{
- private final GpgVersionConsumer consumer;
+ private final GpgVersion gpgVersion;
- private GpgVersionParser( GpgVersionConsumer consumer )
+ private GpgVersionParser( GpgVersion gpgVersion )
Review comment:
The class design is weird anyways: The GpgVersionParser creates/contains a
GpgVersion. But, in fact, this is only the full line as extracted from the
CommandLine executor. If you ask for the SemVer version, the GpgVersion class
has first to do some parsing as well ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
