Tibor17 commented on a change in pull request #245: Surefire-1584: Add option 
to rerun failing tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#discussion_r315601476
 
 

 ##########
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
 ##########
 @@ -259,4 +261,50 @@ else if ( testSource.filter( 
ClassSource.class::isInstance ).isPresent() )
             return new String[] { source, source, display, display };
         }
     }
+
+    public String[] toClassMethodNameWithoutPlan( TestIdentifier 
testIdentifier )
 
 Review comment:
   I am not totally convinced about this method because there is already one 
which returns `String[4]`. I would vote for a generic approach avoiding code 
duplication in single class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to