pmoerenhout commented on a change in pull request #19: [MDEP-579] - Add
mirrors, proxies and authentication for remote repositories.
URL:
https://github.com/apache/maven-dependency-plugin/pull/19#discussion_r315761851
##########
File path: src/test/java/org/apache/maven/plugins/dependency/TestGetMojo.java
##########
@@ -96,6 +117,27 @@ public void testRemoteRepositories()
mojo.execute();
}
+ /**
+ * Test remote repositories parameter with basic authentication
+ *
+ * @throws Exception in case of errors
+ */
+ public void testRemoteRepositoriesAuthentication()
+ throws Exception
+ {
+ org.eclipse.jetty.server.Server server = createServer( 8000 );
+ server.start();
+
+ setVariableValueToObject( mojo, "remoteRepositories",
"myserver::default::http://localhost:8000/maven"; );
+ mojo.setGroupId( "test" );
+ mojo.setArtifactId( "test" );
+ mojo.setVersion( "1.0" );
+
+ mojo.execute();
+
+ server.stop();
Review comment:
I've added the server.stop() to a finally block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
