[GitHub] [maven-surefire] Col-E commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5

[GitBox]

Col-E commented on a change in pull request #245: Surefire-1584: Add option to 
rerun failing tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#discussion_r330129552
 
 

 ##########
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
 ##########
 @@ -47,6 +47,7 @@
     implements TestExecutionListener
 {
     private final ConcurrentMap<TestIdentifier, Long> testStartTime = new 
ConcurrentHashMap<>();
+    private final ConcurrentMap<TestIdentifier, TestExecutionResult> failures 
= new ConcurrentHashMap<>();
 
 Review comment:
   Clearing in `testPlanExecutionFinished` doesn't allow the data to be 
accessible when referenced in `JUnitPlatformProvider#invokeAllTests`. Having it 
clear per-test in `testPlanExecutionStarted` keeps the expected behavior.
   
   Moving the `failures.clear()` as detailed resolves the ITS failures 
mentioned today:
   
![image](https://user-images.githubusercontent.com/21371686/65977509-0b4ac480-e440-11e9-8215-ff3a6b5543c9.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services