Col-E commented on issue #245: Surefire-1584: Add option to rerun failing tests 
for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#issuecomment-537429513
 
 
   > Did you introduce another IT in the next 6 commits too?
   
   The only non-syntax changes are adding `debugLogging()` and updating JUnit 
to `5.5.1`. No additional tests were added.
   
   > You will see it when you use JDK7. Feel free to try.
   
   I'm was on 8 which would explain why I didn't see it.
   
   > We have such conditions in ITs, see `assumeJavaVersion( javaVersion )`.
   > Surefire is compiled with Java 7 and JRE is between 7 - 13
   
   So if I add the following to `JUnitPlatformRerunFailingTestsIT`:
   ```java
       @Before
       public void initialize() 
       {
           assumeJavaVersion( 1.8 );
       }
   ```
   then this should be resolved?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to