eolivelli commented on a change in pull request #60: [WAGON-574] advertise
jsoup license for shaded jar
URL: https://github.com/apache/maven-wagon/pull/60#discussion_r344184546
##########
File path: wagon-providers/wagon-http/pom.xml
##########
@@ -33,6 +33,19 @@ under the License.
Wagon provider that gets and puts artifacts through HTTP(S) using Apache
HttpClient-4.x.
</description>
+ <licenses>
+ <license>
+ <name>Apache License, Version 2.0</name>
+ <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
+ <distribution>repo</distribution>
+ </license>
+ <license>
Review comment:
I am not sure about the official meaning of this tag.
Usually crawlers read this tag to classify the project.
This project is not MIT Licensed and it is not dual licensed.
Maybe it is better to add the 'comment' into the primary ALv2.0 license tag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
