[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004443#comment-17004443
]
Peter De Maeyer commented on MSHADE-339:
----------------------------------------
{quote}
perhaps it's just the attribute name that is just wrongly named as
{{artifactType}} (then implies default classifier) when it is in reality just
{{artifactExtension}}
{quote}
Hmm, I'm not entirely certain, but I don't think think that's true - the
extension is still jar.
The reason I dare say this is because I think I would have noticed that while
fixing.
Even though I didn't write an additional IT, I _did_ run all the _existing_
ITs, and they were all green.
Surely enough, if something so obvious as the file extension would change, it
would make some existing ITs fail (I hope)...
Anyway, point taken: I'll go back to the drawing board and either add a new IT
or update an existing one in my PR to illustrate a scenario that could go wrong.
> Shaded test jar has wrong type "jar"
> ------------------------------------
>
> Key: MSHADE-339
> URL: https://issues.apache.org/jira/browse/MSHADE-339
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.2, 3.2.2
> Reporter: Peter De Maeyer
> Priority: Minor
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
