[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

[GitBox]

klevis commented on issue #261: SUREFIRE-1744 - enable system-out for 
successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573009579
 
 
   @Tibor17 about serializeTestClassWithRerun is quite unclear the right place 
this might needed..
   Anyway looking at the code might be nessesary only for the success case and 
flaky
   `case success:
                   for ( WrappedReportEntry methodEntry : methodEntries )
                   {
                       if ( methodEntry.getReportEntryType() == SUCCESS )
                       {
                           startTestElement( ppw, methodEntry );
                           ppw.endElement();
                       }
                   }`
   `case flake:
                   WrappedReportEntry successful = null;
                   // Get the run time of the first successful run
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() == SUCCESS )
                       {
                           successful = singleRunEntry;
                           break;
                       }
                   }
                   WrappedReportEntry firstOrSuccessful = successful == null ? 
methodEntries.get( 0 ) : successful;
                   startTestElement( ppw, firstOrSuccessful );
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() != SUCCESS )
                       {
                           getTestProblems( fw, ppw, singleRunEntry, 
trimStackTrace, outputStream,
                                   
singleRunEntry.getReportEntryType().getFlakyXmlTag(), true );
                       }
                   }
                   ppw.endElement();
                   break;`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services