michael-o edited a comment on issue #277: [MNG-6732] - DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon ArtifactTransferException URL: https://github.com/apache/maven/pull/277#issuecomment-575820803 > > > How about adding if statement for IGNORE_INVALID? (I'll do experiment next week) I did that: ```patch diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java index 0e9a5745e..da13f363d 100644 --- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java +++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java @@ -245,7 +245,7 @@ private Model loadPom( RepositorySystemSession session, ArtifactDescriptorReques catch ( ArtifactResolutionException e ) { Throwable cause = e.getCause(); - if ( cause instanceof ArtifactTransferException ) + if ( cause instanceof ArtifactNotFoundException ) { missingDescriptor( session, trace, a, (Exception) cause ); if ( ( getPolicy( session, a, request ) & ArtifactDescriptorPolicy.IGNORE_MISSING ) != 0 ) @@ -253,6 +253,14 @@ private Model loadPom( RepositorySystemSession session, ArtifactDescriptorReques return null; } } + if ( cause instanceof ArtifactTransferException ) + { + missingDescriptor( session, trace, a, (Exception) cause ); + if ( ( getPolicy( session, a, request ) & ArtifactDescriptorPolicy.IGNORE_INVALID ) != 0 ) + { + return null; + } + } result.addException( e ); ``` Doesn't make a difference.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
