[ http://jira.codehaus.org/browse/CONTINUUM-1105?page=all ]
Wendy Smoak updated CONTINUUM-1105:
-----------------------------------
Description:
When there is a notifier in the pom, and a group of projects (such as
maven/plugins/trunk/pom.xml) is added under the groupId in the pom, every
notification email is duplicated.
In the UI for each project, the notifier correctly shows "From Project". It
doesn't look like two notifiers have been added.
20070102 IRC conversation about adding maven/plugins/trunk/pom.xml under
various groupIds:
<wsmoak> what could make continuum send duplicate emails?
<wsmoak> I've added and deleted all of maven/plugins/trunk/pom.xml a few times
under different project groups.
<wsmoak> When I add it under the pom default org.apache.maven.plugins group, I
get duplicate emails for every build.
<joakim> wsmoak, have you verified that there are not duplicate entries for
emails in the build defs?
<joakim> I used to get duplicates when I belonged to an distribution-list and a
direct email address.
<wsmoak> joakim: there is only the default build definition, and admin is the
only member of the group
<evenisse> wsmoak: I think we look at project group notifiers too when we look
at project notifier, so we get the project group notifier twice when we send
the mail
<wsmoak> it only happens when I add the projects under the pom default group
id. If I delete and re-add it to some other group, I only get one email.
<evenisse> yes, because, when you use the default project group, project
notifiers are moved to the project group but I think they aren't removed in the
project
<wsmoak> okay. and it's only happening with maven/plugins because struts, etc.
doesn't have notifiers in the pom.
>From the log file (email addresses changed...):
INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
[pool-1-thread-1] INFO ShellCommandHelper:default - Executing: mvn
--batch-mode --non-recursive clean install
INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
[pool-1-thread-1] INFO ShellCommandHelper:default - Working directory:
/opt/continuum-1.1-r490629-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/7
INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,660
[pool-1-thread-1] INFO ContinuumBuildExecutor:maven2 - Exit code: 1
INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,944
[pool-1-thread-1] INFO BuildController:default - Performing action
deploy-artifact
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
[pool-1-thread-1] INFO Notifier:mail - Sending message: From
'"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
[pool-1-thread-1] INFO Notifier:mail - Recipient: To '<[EMAIL
PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
[pool-1-thread-1] INFO Notifier:mail - Sending message: From
'"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
[pool-1-thread-1] INFO Notifier:mail - Recipient: To '<[EMAIL
PROTECTED]>'.
was:
When there is a notifier in the pom, and a group of projects (such as
maven/plugins/trunk/pom.xml) is added under the groupId in the pom, every
notification email is duplicated.
In the UI for each project, the notifier correctly shows "From Project". It
doesn't look like two notifiers have been added.
20070102 IRC conversation about adding maven/plugins/trunk/pom.xml under
various groupIds:
<wsmoak> what could make continuum send duplicate emails?
<wsmoak> I've added and deleted all of maven/plugins/trunk/pom.xml a few times
under different project groups.
<wsmoak> When I add it under the pom default org.apache.maven.plugins group, I
get duplicate emails for every build.
<joakim> wsmoak, have you verified that there are not duplicate entries for
emails in the build defs?
<joakim> I used to get duplicates when I belonged to an distribution-list and a
direct email address.
<wsmoak> joakim: there is only the default build definition, and admin is the
only member of the group
<evenisse> wsmoak: I think we look at project group notifiers too when we look
at project notifier, so we get the project group notifier twice when we send
the mail
<wsmoak> it only happens when I add the projects under the pom default group
id. If I delete and re-add it to some other group, I only get one email.
<evenisse> yes, because, when you use the default project group, project
notifiers are moved to the project group but I think they aren't removed in the
project
<wsmoak> okay. and it's only happening with maven/plugins because struts, etc.
doesn't have notifiers in the pom.
>From the log file (email addresses changed...):
INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
[pool-1-thread-1] INFO ShellCommandHelper:default - Executing: mvn
--batch-mode --non-recursive clean install
INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
[pool-1-thread-1] INFO ShellCommandHelper:default - Working directory:
/opt/continuum-1.1-r490629-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/7
INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,660
[pool-1-thread-1] INFO ContinuumBuildExecutor:maven2 - Exit code: 1
INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,944
[pool-1-thread-1] INFO BuildController:default - Performing action
deploy-artifact
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
[pool-1-thread-1] INFO Notifier:mail - Sending message: From
'"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
[pool-1-thread-1] INFO Notifier:mail - Recipient: To '<[EMAIL
PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
[pool-1-thread-1] INFO Notifier:mail - Sending message: From
'"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
[pool-1-thread-1] INFO Notifier:mail - Recipient: To '<[EMAIL
PROTECTED]>'.
Either
* the 'add project' logic should remove the notifier from projects if it is
added at the group level, or
* Continuum should filter out duplicate recipients before sending.
> Duplicate email notifications with notifier in pom.xml
> ------------------------------------------------------
>
> Key: CONTINUUM-1105
> URL: http://jira.codehaus.org/browse/CONTINUUM-1105
> Project: Continuum
> Issue Type: Bug
> Components: Notifier - Mail
> Affects Versions: 1.1
> Reporter: Wendy Smoak
>
> When there is a notifier in the pom, and a group of projects (such as
> maven/plugins/trunk/pom.xml) is added under the groupId in the pom, every
> notification email is duplicated.
> In the UI for each project, the notifier correctly shows "From Project". It
> doesn't look like two notifiers have been added.
> 20070102 IRC conversation about adding maven/plugins/trunk/pom.xml under
> various groupIds:
> <wsmoak> what could make continuum send duplicate emails?
> <wsmoak> I've added and deleted all of maven/plugins/trunk/pom.xml a few
> times under different project groups.
> <wsmoak> When I add it under the pom default org.apache.maven.plugins group,
> I get duplicate emails for every build.
> <joakim> wsmoak, have you verified that there are not duplicate entries for
> emails in the build defs?
> <joakim> I used to get duplicates when I belonged to an distribution-list and
> a direct email address.
> <wsmoak> joakim: there is only the default build definition, and admin is
> the only member of the group
> <evenisse> wsmoak: I think we look at project group notifiers too when we
> look at project notifier, so we get the project group notifier twice when we
> send the mail
> <wsmoak> it only happens when I add the projects under the pom default group
> id. If I delete and re-add it to some other group, I only get one email.
> <evenisse> yes, because, when you use the default project group, project
> notifiers are moved to the project group but I think they aren't removed in
> the project
> <wsmoak> okay. and it's only happening with maven/plugins because struts,
> etc. doesn't have notifiers in the pom.
> From the log file (email addresses changed...):
> INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
> [pool-1-thread-1] INFO ShellCommandHelper:default - Executing: mvn
> --batch-mode --non-recursive clean install
> INFO | jvm 1 | 2007/01/02 20:16:39 | 2007-01-02 20:16:39,831
> [pool-1-thread-1] INFO ShellCommandHelper:default - Working directory:
> /opt/continuum-1.1-r490629-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/7
> INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,660
> [pool-1-thread-1] INFO ContinuumBuildExecutor:maven2 - Exit code: 1
> INFO | jvm 1 | 2007/01/02 20:16:41 | 2007-01-02 20:16:41,944
> [pool-1-thread-1] INFO BuildController:default - Performing action
> deploy-artifact
> INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
> [pool-1-thread-1] INFO Notifier:mail - Sending message:
> From '"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
> INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,072
> [pool-1-thread-1] INFO Notifier:mail - Recipient: To
> '<[EMAIL PROTECTED]>'.
> INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
> [pool-1-thread-1] INFO Notifier:mail - Sending message:
> From '"[EMAIL PROTECTED]" <[EMAIL PROTECTED]>'.
> INFO | jvm 1 | 2007/01/02 20:16:42 | 2007-01-02 20:16:42,337
> [pool-1-thread-1] INFO Notifier:mail - Recipient: To
> '<[EMAIL PROTECTED]>'.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
