[GitHub] [maven-assembly-plugin] turbanoff edited a comment on issue #16: [MASSEMBLY-874] maven-assembly plugin always downloads dependencies from net

[GitBox]

turbanoff edited a comment on issue #16: [MASSEMBLY-874] maven-assembly plugin 
always downloads dependencies from net
URL: 
https://github.com/apache/maven-assembly-plugin/pull/16#issuecomment-579494558
 
 
   I stuck with integration test.
   Looks like it's too hard or impossible to write proper regression test.
   Cause of this is that `setRemoteRepositories` is always called in 
integration test in this stack trace (i updated maven-code version to 3.6.3 to 
match my maven installation)
   ```
    at 
org.apache.maven.project.DefaultProjectBuildingRequest.setRemoteRepositories(DefaultProjectBuildingRequest.java:132)
          at 
org.apache.maven.project.DefaultProjectBuilder.initProject(DefaultProjectBuilder.java:642)
          at 
org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:583)
          at 
org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:372)
          at 
org.apache.maven.graph.DefaultGraphBuilder.collectProjects(DefaultGraphBuilder.java:400)
          at 
org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor(DefaultGraphBuilder.java:391)
          at 
org.apache.maven.graph.DefaultGraphBuilder.build(DefaultGraphBuilder.java:78)
          at org.apache.maven.DefaultMaven.buildGraph(DefaultMaven.java:511)
          at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:221)
          at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
          at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
          at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
          at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
          at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
          at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-1)
          at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:566)
          at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
          at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
          at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
          at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
   ```
   
   This method `setRemoteRepositories` is not called in my production case 
because parentModel == `null` here 
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java#L912
   
![изображение](https://user-images.githubusercontent.com/741251/73310871-2da9ee80-4236-11ea-88e9-ba00c4e6cb54.png)
   
   Since integration tests in maven-assembly-plugins always has parent 
https://github.com/apache/maven-assembly-plugin/blob/master/src/it/it-project-parent/pom.xml
 in their case it's always `!= null`
   
![изображение](https://user-images.githubusercontent.com/741251/73311229-043d9280-4237-11ea-8c9e-51203722791a.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services