albfan commented on a change in pull request #36: WIP: Add feature no create
base dir
URL: https://github.com/apache/maven-archetype/pull/36#discussion_r373840917
##########
File path:
archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
##########
@@ -136,7 +136,8 @@ public void generateArchetype( ArchetypeGenerationRequest
request, File archetyp
String packageName = request.getPackage();
String artifactId = request.getArtifactId();
- File outputDirectoryFile = new File( request.getOutputDirectory(),
artifactId );
+ File outputDirectoryFile = new File( request.getOutputDirectory(),
Review comment:
I think this makes more sense:
File outputDirectoryFile = request.isCreateBaseDir() ? new File(
request.getOutputDirectory(), artifactId): request.getOutputDirectory();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
