[ 
https://issues.apache.org/jira/browse/MCOMPILER-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070029#comment-17070029
 ] 

Jeremy Landis commented on MCOMPILER-339:
-----------------------------------------

Please note: For clarity.  The usage is correct of 'release'.  Its the fact 
that if jdk 8 is used to compile, that shouldn't be provided to java.  It 
doesn't work.  It cannot give false impression it will, it won't.  It's not 
valid for that jdk and the jdk will rejected the compilation.  Thus I'm not 
seeing danger here at all.  I'd be happen if there was just a flag for that 
considered danger.  Default as it does now, but let me configure it to ignore 
invalid parameters.

> Skip --release flag if compilerVersion is lower than 1.9
> --------------------------------------------------------
>
>                 Key: MCOMPILER-339
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-339
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.7.0
>            Reporter: David J. M. Karlsen
>            Priority: Major
>
> usecase: I have a build which is jdk10 by default, declared via the 
> parent-pom.
>  However, one submodule must be compiled and run with java8. I had hoped to 
> get this working, by setting:
> {noformat}
> <properties>
>   <maven.compiler.release>8</maven.compiler.release>
>   <maven.compiler.source>1.8</maven.compiler.source>
>   <maven.compiler.target>1.8</maven.compiler.target>
>   <maven.compiler.compilerVersion>1.8</maven.compiler.compilerVersion>
> </properties>
> {noformat}
>  
> but it will fail with 
> {noformat}
> Caused by: java.lang.IllegalArgumentException: invalid flag: 
> --release*11:53:45*     at com.sun.tools.javac.api.JavacTool.processOptions 
> (JavacTool.java:206)*11:53:45*     at 
> com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:156)*11:53:45*     
> at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:107)*11:53:45*   
>   at com.sun.tools.javac.api.JavacTool.getTask (JavacTool.java:64)*11:53:45*  
>    at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess 
> (JavaxToolsCompiler.java:125)*11:53:45*     at 
> org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile 
> (JavacCompiler.java:174)*11:53:45*     at 
> org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute 
> (AbstractCompilerMojo.java:1075)*11:53:45*     at 
> org.apache.maven.plugin.compiler.TestCompilerMojo.execute 
> (TestCompilerMojo.java:176)*11:53:45*     at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:134)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:208)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:154)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:146)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
>  (MultiThreadedBuilder.java:200)*11:53:45*     at 
> org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
>  (MultiThreadedBuilder.java:196)*11:53:45*     at 
> java.util.concurrent.FutureTask.run (FutureTask.java:266)*11:53:45*     at 
> java.util.concurrent.Executors$RunnableAdapter.call 
> (Executors.java:511)*11:53:45*     at java.util.concurrent.FutureTask.run 
> (FutureTask.java:266)*11:53:45*     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker 
> (ThreadPoolExecutor.java:1149)*11:53:45*     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run 
> (ThreadPoolExecutor.java:624)*11:53:45*     at java.lang.Thread.run 
> (Thread.java:748)
> {noformat}
> If the release flag could only be enabled for compiler versions supporting it 
> it would be easier to juggle the build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to