[ 
https://issues.apache.org/jira/browse/SCM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077328#comment-17077328
 ] 

Michael Osipov commented on SCM-932:
------------------------------------

This really sounds like going against the convention over configuration. You 
have to consider to integrate it into the Maven approach or manage it by some 
other means. I will look at your patch over the weekend. You may turn that into 
a PR if you like.

> JGit does not commit files in fileset based in subfolder
> --------------------------------------------------------
>
>                 Key: SCM-932
>                 URL: https://issues.apache.org/jira/browse/SCM-932
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-jgit
>    Affects Versions: 1.11.2
>            Reporter: Alex Harui
>            Priority: Major
>         Attachments: SCM-932-Test.patch, SCM-932.patch
>
>
> If `mvn release` is run in a subfolder, the changed files are relative to the 
> subfolder and not the repo root and `maven-scm-provider-jgit` does not 
> compute the correct path and thus the files are not added and committed.
> For example, a git repo is created at `repo-root`
> {code:java}
> repo-root/pom.xml
> repo-root/unparented-submodule/pom.xml {code}
> The user does:
> {code:java}
> cd repo-root/unparented-submodule
> mvn release:prepare {code}
> A `git status` will show that `unparented-submodule/pom.xml` is changed and 
> not staged for commit.  That's because the fileset's basedir is 
> `unpainted-submodule` and the relative path is just `pom.xml`. 
> `maven-scm-provider-jgit` 1.12.1 tries to stage 'pom.xml' not 
> `unparented-submodule/pom.xml` and since repo-root/pom.xml has not changed, 
> nothing is in the commit and `unparented-submodule/pom.xml` remains un-staged.
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to