Tibor17 commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-629624526


   @cowwoc 
   @sormuras 
   We need to answer the following question quite fast.
   
   Currently this is the Java arg file we generate by the plugin in order the 
`src/main/java/module-info.java` exists (or java version e.g. `java15`).
   What should be changed in this arg file?
   
   ```
   --module-path
   
"C:\\vcs\\release\\RELEASE-3.0.0-M1\\surefire-its\\src\\test\\resources\\java9-full-api\\target\\java9-full-api-1.0.jar"
   --class-path
   
"c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-booter\\3.0.0-SNAPSHOT\\surefire-booter-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-api\\3.0.0-SNAPSHOT\\surefire-api-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-logger-api\\3.0.0-SNAPSHOT\\surefire-logger-api-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-shared-utils\\3.0.0-M4\\surefire-shared-utils-3.0.0-M4.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-extensions-spi\\3.0.0-SNAPSHOT\\surefire-extensions-spi-3.0.0-SNAPSHOT.jar;C:\\vcs\\release\\RELEASE-3.0.0-M1\\surefire-its\\src\\test\\resources\\java9-full-api\\target\\test-classes;c:\\Users\\tibor17\\.m2\\repository\\junit\\junit\\4.13\\junit-4.13.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\hamcrest\\hamcrest-core\\1.3\\hamcrest-core-1.3.jar;c:\\Users\\tibor17\\.m2\\repository\\javax\\transaction\\javax.transaction-api\\1.2\\javax.transaction-api-1.2.jar;c:\\Users\\tibor17\\.m2\\repository\\javax\\xml\\ws\\jaxws-api\\2.3.0\\jaxws-api-2.3.0.jar;c:\\Users\\tibor17\\.m2\\repository\\javax\\xml\\soap\\javax.xml.soap-api\\1.4.0\\javax.xml.soap-api-1.4.0.jar;c:\\Users\\tibor17\\.m2\\repository\\javax\\xml\\bind\\jaxb-api\\2.3.0\\jaxb-api-2.3.0.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\surefire-junit4\\3.0.0-SNAPSHOT\\surefire-junit4-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\common-java5\\3.0.0-SNAPSHOT\\common-java5-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\common-junit3\\3.0.0-SNAPSHOT\\common-junit3-3.0.0-SNAPSHOT.jar;c:\\Users\\tibor17\\.m2\\repository\\org\\apache\\maven\\surefire\\common-junit4\\3.0.0-SNAPSHOT\\common-junit4-3.0.0-SNAPSHOT.jar"
   --patch-module
   
java9.full.api="C:\\vcs\\release\\RELEASE-3.0.0-M1\\surefire-its\\src\\test\\resources\\java9-full-api\\target\\test-classes"
   --add-exports
   java9.full.api/J9IT=ALL-UNNAMED
   --add-modules
   java9.full.api
   --add-reads
   java9.full.api=ALL-UNNAMED
   org.apache.maven.surefire.booter.ForkedBooter
   ```
   
   I guess we will remove the lines 5 - 12.
   This meand `--patch-module`, `--add-exports`, `--add-modules`, `--add-reads`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to