mabrarov commented on a change in pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r505737237
########## File path: src/test/resources/projects/project-094/ear/pom.xml ########## @@ -0,0 +1,100 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>ear</groupId> + <artifactId>maven-ear-plugin-test-project-094-parent</artifactId> + <version>99.0</version> + </parent> + <artifactId>maven-ear-plugin-test-project-094</artifactId> + <packaging>ear</packaging> + <dependencies> + <dependency> + <groupId>eartest</groupId> + <artifactId>jar-sample-three-with-deps</artifactId> + </dependency> + <dependency> + <groupId>eartest</groupId> + <artifactId>war-sample-three</artifactId> + <type>war</type> + </dependency> + <dependency> + <groupId>eartest</groupId> + <artifactId>sar-sample-two</artifactId> + <type>sar</type> + <!-- + By some reason dependencies of SAR come into EAR as transitive dependencies while they should not, + because SAR contains its dependencies packaged as libraries (like WAR). + Looks like a bug of SAR packaging, i.e. bug of JBoss Packaging Maven Plugin where + includesDependencies should be explicitly set to true for Review comment: Refer to [that comment](https://github.com/mojohaus/jboss-packaging-maven-plugin/commit/bf85249a7514aff3729c862faf7bcfed274a522b#r43279570) in [jboss-packaging-maven-plugin](https://github.com/mojohaus/jboss-packaging-maven-plugin) GitHub project. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org