[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

Fri, 16 Oct 2020 03:13:24 -0700 


bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506256133



##########
File path: 
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##########
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest 
performRequest, ReleaseResult result
             ReleaseUtils.buildReleaseDescriptor( 
performRequest.getReleaseDescriptorBuilder() )
             .getActivateProfiles();
 
-        ReleaseDescriptor releaseDescriptor =
-            loadReleaseDescriptor( 
performRequest.getReleaseDescriptorBuilder(),
-                                   performRequest.getReleaseManagerListener() 
);
+        ReleaseDescriptorBuilder builder =
+            loadReleaseDescriptorBuilder( 
performRequest.getReleaseDescriptorBuilder(),
+                                          
performRequest.getReleaseManagerListener() );
 
         if ( specificProfiles != null && !specificProfiles.isEmpty() )
         {
+            List<String> allProfiles = new ArrayList<>();

Review comment:
       Some background is in 
https://issues.apache.org/jira/browse/MRELEASE-1042 also ...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to