michaelboyles commented on pull request #76: URL: https://github.com/apache/maven-resolver/pull/76#issuecomment-710431377
I didn't miss them. I decided not to change them. **DefaultDependencyCollector partially (line 758)** It's a NodeStack. A custom class which does not support iterators. It only has size() and get(). I could add an iterator method, but its backed by an array, so already has constant time random access. Wouldn't give any performance benefit **PathRecordingDependencyVisitor** Again, custom class backed by an array, this time Stack. Could change to this ``` List<DependencyNode> path = new ArrayList<>( this.parents ); Collections.reverse( path ); paths.add( path ); ``` which I think is the same result but more expressive. Probably actually slower because of the copy-then-reverse. Or at least, no performance benefit ***GenericVersion*** As far as I can tell, the index is necessary ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
