[ 
https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231397#comment-17231397
 ] 

Tibor Digana commented on SUREFIRE-1854:
----------------------------------------

[~adam11grafik]
It's quite easy, just open a new PR on 
[GitHub|http://github.com/apache/maven-surefire] and name the PR and final 
commit {{[SUREFIRE-1854] Support include/exclude junit test engine}}.
My recommendation is to start with simple commits and I will guide you there 
with review. Finally, the CI should pass on GitHub and the PR should be 
squashed and rebased on master.
The name of branch does not matter if it is named master. We develop in master 
yet.
The module {{surefire-junit-platform}} has few tests classes and the provider 
is tested there. It's important that your build works locally before you start.
So fork the project from GitHub and try to run these commands, you should get 
successful build with unit tests:

{{mvn install -nsu -DskipTests}}

{{mvn -nsu -f surefire-providers/surefire-junit-platform/pom.xml test}}

or run the test suite in IDEA which is easier.
The next step would be the ITs but let's leave it on the GH Worflows.
Of course new unit tests must be written for your work with a coverage which 
does not go down.

> Support include/exclude junit test engine
> -----------------------------------------
>
>                 Key: SUREFIRE-1854
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1854
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: JUnit 5.x support, Maven Surefire Plugin
>    Affects Versions: 2.22.2
>            Reporter: Adam
>            Priority: Major
>
> It could be very important for my project to support include/exclude junit 
> test engine by Maven Surefire Plugin.
> Junit Console Launcher have existing support for this:
> [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options]
> Similar solution exists for Gradle:
> https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to