michael-o commented on a change in pull request #12:
URL: https://github.com/apache/maven-deploy-plugin/pull/12#discussion_r542003179
##########
File path: src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java
##########
@@ -51,6 +51,9 @@
public class DeployMojo
extends AbstractDeployMojo
{
+ private static final Pattern ALT_INVALID_REPO_SYNTAX_PATTERN =
Pattern.compile( "(.+)::(.+)::(.+)::(.+)" );
Review comment:
I do not fully understand the purpose of this. You can extend this ad
absurdum with zillions of double-colons. We cannot avoid this, but is not wrong:
`funny-id::https:///server/some/url/sub::/...`. I would rather drop this and
make both other formats non-greedy all `n-1` matching groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
