pzygielo commented on a change in pull request #68:
URL: https://github.com/apache/maven-shared-utils/pull/68#discussion_r549652414
##########
File path:
src/test/java/org/apache/maven/shared/utils/cli/CommandLineUtilsTest.java
##########
@@ -168,4 +169,18 @@ private void assertCmdLineArgs( final String[] expected,
final String cmdLine )
assertEquals( expected.length, actual.length );
assertEquals( Arrays.asList( expected ), Arrays.asList( actual ) );
}
+
+ @Test
+ public void environmentVariableWithNullShouldBeAddToList() {
+
+ Commandline commandline = new Commandline();
+ commandline.addEnvironment("TEST_NULL_ENV", null);
+
+ String[] environmentVariables = commandline.getEnvironmentVariables();
+ assertNotNull(environmentVariables);
+ for (String variable: environmentVariables) {
+ assertFalse("Variable '" + variable + "' shouldn't be set",
Review comment:
conflicts with test name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
