michael-o commented on pull request #88: URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-758102450
> > > Another strange thing I just now realized: if you look at `org.eclipse.aether.impl.guice.AetherModule`, bindings are in `Singleton` scope. But, if you look at corresponding classes, they have `@Named` annontation only. This means, that **SISU will NOT treat them as singletons** (but as "prototype")! IMO, this is a mistake, as these components are meant to be singletons... Indeed! Let's move this to a new PR please. Checked most classes and there is no reason why they should not be reused. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
