michael-o commented on pull request #411:
URL: https://github.com/apache/maven/pull/411#issuecomment-770722429
@rfscholte The profile detection (MNG-7051) will be merged soon, but still
there is no way to fail explicitly here because the profile is activated with a
property:
```
osipovmi@deblndw011x:~/var/Projekte/maven-release (master=)
$ grep -r performRelease .
./maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java:
* If set to true, this will set the property "performRelease" to true.
./maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
additionalArguments = additionalArguments + "
-DperformRelease=true";
./maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
additionalArguments = "-DperformRelease=true";
./maven-release-manager/src/main/mdo/release-descriptor.mdo: If
set to true, this will set the property "performRelease" to true.
./maven-release-manager/src/test/java/org/apache/maven/shared/release/exec/ForkedMavenExecutorTest.java:
String arguments = "-DperformRelease=true -Dmaven.test.skip=true";
./maven-release-manager/src/test/java/org/apache/maven/shared/release/exec/ForkedMavenExecutorTest.java:
verify( argMock ).setLine( "-DperformRelease=true
-Dmaven.test.skip=true" );
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-DperformRelease=true -f pom.xml" ),
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-DperformRelease=true -f pom.xml" ),
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-DperformRelease=true -f pom1.xml" ),
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-DperformRelease=true -f pom.xml" ),
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-Dmaven.test.skip=true
-DperformRelease=true -f pom.xml" ),
./maven-release-manager/src/test/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhaseTest.java:
eq( "-DperformRelease=true -f pom.xml" ),
./maven-release-plugin/src/it/projects/perform/MRELEASE-459/verify.groovy:def
addArgsExpr = /\Q[DEBUG] Additional arguments: \E(?:-Dhttps.protocols=TLSv1.2
)?-P(.+)\Q-DperformRelease=true -f pom.xml\E/
./maven-release-plugin/src/it/projects/perform/MRELEASE-459/verify.groovy://
M2: [DEBUG] Additional arguments: -P custom-release -DperformRelease=true -f
pom.xml
./maven-release-plugin/src/it/projects/perform/MRELEASE-459/verify.groovy://
M3: [DEBUG] Additional arguments: -P it-repo,it-repo,custom-release
-DperformRelease=true -f pom.xml
./maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java:
* If set to true, the release plugin sets the property "performRelease" to
true, which activates the profile
```
Still any objections to merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
