MartinKanters commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r577045936
########## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java ########## @@ -242,21 +274,17 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep { List<MavenProject> result = projects; - if ( !request.getExcludedProjects().isEmpty() ) + ProjectActivation projectActivation = request.getProjectActivation(); + Set<String> requiredSelectors = projectActivation.getRequiredInactiveProjectSelectors(); + Set<String> optionalSelectors = projectActivation.getOptionalInactiveProjectSelectors(); + if ( !requiredSelectors.isEmpty() || !optionalSelectors.isEmpty() ) { - File reactorDirectory = getReactorDirectory( request ); + Set<MavenProject> excludedProjects = new HashSet<>( requiredSelectors.size() + optionalSelectors.size() ); + excludedProjects.addAll( getProjectsBySelectors( request, projects, requiredSelectors, true ) ); + excludedProjects.addAll( getProjectsBySelectors( request, projects, optionalSelectors, false ) ); Review comment: I agree, but I don't think I understand how it would ideally work. Would you want to let `-a,+:a` work the same way as `-a,+a` instead of have the exception thrown? (last one wins) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org