elharo commented on a change in pull request #61: URL: https://github.com/apache/maven-doxia/pull/61#discussion_r639660055
########## File path: .github/workflows/maven.yml ########## @@ -0,0 +1,44 @@ + # Licensed to the Apache Software Foundation (ASF) under one Review comment: This should be in a separate PR as it's not directly related to fixing this bug ########## File path: doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java ########## @@ -1658,6 +1659,35 @@ public void tableHeaderCell( SinkEventAttributes attributes ) private void tableCell( boolean headerRow, MutableAttributeSet attributes ) { Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD ); + + if ( !headerRow + && null != this.cellCountStack Review comment: this.foo != null is far more common and unsurprising. Putting the literal first is a C convention not needed in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org