kriegaex edited a comment on pull request #354:
URL: https://github.com/apache/maven-surefire/pull/354#issuecomment-872660294


   > See the last commit. I had this change in #343 and missed in this PR.
   
   That explains it. 🙂
   
   > Pls update Surefire with this branch, test it.
   
   I tested both branches with Java 8 and 16. Everything works fine. I also 
tried again in my project Sarek, and it also works. What is irritating, though, 
is that I also tried to reproduce the problem with M5 again, but the build did 
not hang there either. I remember it always did before, but it was so long 
ago... From my perspective, this can be merged as soon as the ITs are in and 
doing the right thing. I can help run the ITs, both on master before this fix 
(in order to see, if stopping the hanging process after a timeout works as 
expected in case of a regression) and after it in the bugfix branch.
   
   > Lets add the IT today..
   
   Good idea. 👍
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to