kriegaex opened a new pull request #104: URL: https://github.com/apache/maven-shade-plugin/pull/104
I wanted to avoid re-creating @JanMosigItemis's PR #83 and make sure he gets the recognition he deserves for taking initiative and creating a PR for the change I suggested in my [comment in MSHADE-366](https://issues.apache.org/jira/browse/MSHADE-366?focusedCommentId=17273260&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17273260). So I have committed on top of his changes, also retaining a refactored version of the new tests he created. Thank you, Jan! I took the chance not only to fix actual the problem, but also to factor out two helper methods from `removeServices`, because that method was way too big to still be readable. Supersedes #83. @rmannibucau, please continue reviewing here. Let's get this thing merged ASAP. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
