michael-o commented on a change in pull request #556:
URL: https://github.com/apache/maven/pull/556#discussion_r718427758
##########
File path: apache-maven/src/assembly/shared/init
##########
@@ -20,7 +20,7 @@ if [ -n "$JAVA_HOME" ] ; then
fi
fi
else
- JAVACMD="`which java`"
+ JAVACMD="`\\unalias -a; unset -f command; command -v java`"
Review comment:
* Do you assume as `unalias` could be an alias as well?
* Why are you unset all alias? Do you assume `java(1)` to be an alias?
##########
File path: apache-maven/src/assembly/shared/init
##########
@@ -20,7 +20,7 @@ if [ -n "$JAVA_HOME" ] ; then
fi
fi
else
- JAVACMD="`which java`"
+ JAVACMD="`\\unalias -a; unset -f command; command -v java`"
Review comment:
* Do you assume that `unalias` could be an alias as well?
* Why are you unset all alias? Do you assume `java(1)` to be an alias?
##########
File path: apache-maven/src/assembly/shared/init
##########
@@ -20,7 +20,7 @@ if [ -n "$JAVA_HOME" ] ; then
fi
fi
else
- JAVACMD="`which java`"
+ JAVACMD="`\\unalias -a; unset -f command; command -v java`"
Review comment:
* Do you assume that `unalias` could be an alias as well?
* Why are you unset all aliases? Do you assume `java(1)` to be an alias?
##########
File path: apache-maven/src/assembly/shared/init
##########
@@ -20,7 +20,7 @@ if [ -n "$JAVA_HOME" ] ; then
fi
fi
else
- JAVACMD="`which java`"
+ JAVACMD="`\\unalias -a; unset -f command; command -v java`"
Review comment:
* Do you assume that `unalias` could be an alias as well?
* Why are you unset all aliases? Do you assume `java(1)` to be an alias?
* `unset` is to use the shell builtin only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
