[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #393: [SUREFIRE-1954] move inner class ProviderList to upper level

[GitBox]

slawekjaranowski commented on a change in pull request #393:
URL: https://github.com/apache/maven-surefire/pull/393#discussion_r748827350



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1197,13 +1200,12 @@ private void executeAfterPreconditionsChecked( @Nonnull 
DefaultScanResult scanRe
         throws MojoExecutionException
     {
         Artifact junitDepArtifact = getJunitDepArtifact();
-        return new ProviderList( new DynamicProviderInfo( null ),
-                              new JUnitPlatformProviderInfo( 
getJUnit5Artifact(), testClasspath ),
-                              new TestNgProviderInfo( getTestNgArtifact() ),
-                              new JUnitCoreProviderInfo( getJunitArtifact(), 
junitDepArtifact ),
-                              new JUnit4ProviderInfo( getJunitArtifact(), 
junitDepArtifact ),
-                              new JUnit3ProviderInfo() )
-            .resolve();
+        return providerDetector.resolve( new DynamicProviderInfo( null ),

Review comment:
       now providerDetector is component, so we use service method
   Code from inner class `ProviderList` are in `ProviderDetector`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org