cstamas commented on a change in pull request #131:
URL: https://github.com/apache/maven-resolver/pull/131#discussion_r755145112
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/NamedLockFactoryAdapter.java
##########
@@ -52,6 +53,13 @@ public NamedLockFactoryAdapter( final NameMapper nameMapper,
final NamedLockFact
{
this.nameMapper = Objects.requireNonNull( nameMapper );
this.namedLockFactory = Objects.requireNonNull( namedLockFactory );
+ if ( this.namedLockFactory instanceof FileSystemFriendly
+ && !( this.nameMapper instanceof FileSystemFriendly ) )
+ {
+ throw new IllegalArgumentException(
Review comment:
IAE as if this happens, it means a) user selected them (as default ones
are not marked ones, so we do not enter here) and b) user paired wrong ones.
So, a) + b) simply means "wrong combo set by user" -> IAE IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
