slawekjaranowski commented on a change in pull request #94:
URL: https://github.com/apache/maven-shared-utils/pull/94#discussion_r777688736
##########
File path: src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
##########
@@ -198,14 +200,13 @@ public void addArguments( String... line )
*/
public void addEnvironment( String name, String value )
{
- //envVars.add( name + "=" + value );
envVars.put( name, value );
}
/**
* Add system environment variables.
*/
- public void addSystemEnvironment()
+ private void addSystemEnvironment()
Review comment:
Yes I know, this method is confusing because it is used internally in
`getEnvironmentVariables`.
So when we switch to `4.0.0` I think that can break api in this point.
Now will be setShellEnvironmentInherited for achieve this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
